Generating a dynamic zip file in PHP crashes with non-image files. (V.h.)

I have a function that takes uploaded files (WORDPRESS) and adds them to a (newly created) zip file. each new file is added to the zip (if not already created - the first file will create it), as well as a comment with a list of files.

 function Ob99_generate_zip_file($meta) {
     // we always need post_id , right ?
    if( isset($_GET['post_id']) ) {
            $post_id = $_GET['post_id'];
        } elseif( isset($_POST['post_id']) ) {
            $post_id = $_POST['post_id'];
        }
        //setting some more variables.
        $file =  wp_upload_dir();// take array
        $file2 = wp_upload_dir();//debug
        $zipname = $file['path'].'file.zip'; // set zip file name
        $file = trailingslashit($file['basedir']).$meta['file'];// construct real path

            // Without this next condition the function dies. WHY ??
        list($orig_w, $orig_h, $orig_type) = @getimagesize($file); // not help to comment
        if (!$orig_type == IMAGETYPE_GIF || !$orig_type == IMAGETYPE_PNG|| !$orig_type == IMAGETYPE_JPEG) { 
         //why other filetypes not working ??
         return ;
        }

    $zip = new ZipArchive; // initiatte class
    $zip->open($zipname , ZipArchive::CREATE); // open buffer
    $new_filename = substr($file,strrpos($file,'/') + 1); //we do not need nested folders
    $zip->addFile($file,$sitename.'/'.$new_filename); // we add the file to the zip
    if (file_exists($zipname)){
    $comment = $zip->getArchiveComment();  // if the file already exist read the comment
    } 
    else { // if not - letΒ΄s give it a cool retro header
    $comment_head = '*********************************'. PHP_EOL ;
    $comment_head .= '****** <<< FILE CONTENT >>> *****'. PHP_EOL ;
    $comment_head .= '*********************************'. PHP_EOL ;

    }
    $comment = $comment_head . $comment ;// add header before comment
    $comment = $comment . PHP_EOL . PHP_EOL . $meta['file'] ; // add new file name
    $zip->setArchiveComment($comment); // and comment
    $zip->addFromString('filelist.txt', $comment); // create txt file with the same list
    $zip->close()or die('can not create zip file'.$file.print_r($meta).'---- DEBUG SEPERATOR ---- '.print_r($file2));  // FINISHED or DIE with debug
    }

      

My problem: if I try to load any file other than an image, the function is DIE. I added a condition to check imagetype - but I would like to know why it fails and how to make it work without the specified condition ... Does the zip function have any problems with PDF, doc or whatever? is this a wordpress problem?

+3


source to share


1 answer


It seems that in the problem section, you are asking for PDFs, etc. their image size. Why don't you try:



$image_size = getimagesize($file);

if($image_size===false)
{
   // This is not an image
   // Do what you want to PDFs, etc.
}
else
{
   // This is an image
   // Find out image type, dimensions, etc.
}

      

0


source







All Articles