ListView scrolling error: position selection
I have a Listview that I am trying to display my custom Adapter.Everything works fine only when I select a list item and scroll through it, the items that were not selected are already selected. I really don't understand what the question is with my list.
Here's my class:
@Override
protected void onCreate(Bundle savedInstanceState)
{
// TODO Auto-generated method stub
super.onCreate(savedInstanceState);
setContentView(R.layout.select_contact_layout);
getActionBar().setHomeButtonEnabled(true);
getActionBar().setDisplayHomeAsUpEnabled(true);
getActionBar().setTitle("Select Contact");
mArrayAdapter = new CustomAdapter(this,getContacts());
setListAdapter(mArrayAdapter);
contactPreferences = getSharedPreferences("contactPref", MODE_PRIVATE);
mListView = getListView();
}
@Override
protected void onListItemClick(ListView l, View v, int position, long id)
{
super.onListItemClick(l, v, position, id);
String name = mArrayAdapter.getItem(position).getName();
v.setBackgroundColor(Color.parseColor("#88dfdf"));
Toast.makeText(getApplicationContext(), "Items Pos: " + position +"and Name : "+ name, 0).show();
}
and My Custom Adapter:
class CustomAdapter extends ArrayAdapter<Contacts>
{
LayoutInflater layoutInflater;
private List<Contacts> conctactList;
public CustomAdapter(Context context, List<Contacts> mList)
{
super(context, R.layout.single_contact_layout,mList);
this.conctactList = mList;
layoutInflater = LayoutInflater.from(context);
}
@Override
public int getCount() {
// TODO Auto-generated method stub
return conctactList.size();
}
@Override
public Contacts getItem(int position) {
// TODO Auto-generated method stub
return conctactList.get(position);
}
@Override
public long getItemId(int position) {
// TODO Auto-generated method stub
return position;
}
@Override
public View getView(final int position, View convertView, ViewGroup parent)
{
final Holder holder;
Bitmap bitmap = null;
Bitmap scaleBitmap = null;
if(convertView == null)
{
holder = new Holder();
convertView = layoutInflater.inflate(R.layout.single_contact_layout, null);
holder.name = (TextView) convertView.findViewById(R.id.contact_name);
holder.number = (TextView) convertView.findViewById(R.id.contact_number);
holder.contact_img = (ImageView)convertView.findViewById(R.id.contact_img);
convertView.setTag(holder);
convertView.setTag(R.id.contact_name, holder.name);
}
else{
holder = (Holder) convertView.getTag();
}
holder.name.setText(conctactList.get(position).getName());
holder.number.setText(conctactList.get(position).getNumber());
try {
bitmap = MediaStore.Images.Media.getBitmap(getContentResolver(), Uri.parse(contactsList.get(position).getImgUri()));
scaleBitmap = Bitmap.createScaledBitmap(bitmap, 100, 100, true);
} catch (IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
holder.contact_img.setImageBitmap(ImageHelper.getRoundedCornerBitmap(scaleBitmap, 100));
return convertView;
}
}
private static class Holder{
TextView name;
TextView number;
ImageView contact_img;
}
source to share
v.setBackgroundColor(Color.parseColor("#88dfdf"));
You must not only do this, but also have ArrayList<Boolean> selectedList
one that you "remember" if an item is selected. Then in getView you have to "check" this list and place the color accordingly.
if ( selectedList.get(position) )
convertView.setBackgroundColor(Color.parseColor("#88dfdf"));
else
convertView.setBackgroundColor(Color.parseColor( normal color ));
List initialization in adapter class:
ArrayList<Boolean> selectedList = new ArrayList<Boolean>();
public CustomAdapter(Context context, List<Contacts> mList)
{
.........
int nr = -1;
while (++nr < mList.size() )
selectedList.add(false);
}
}
also add this to getView () function
public View getView(final int position, View convertView, ViewGroup parent)
{ ...............................
holder.contact_img.setImageBitmap(ImageHelper.getRoundedCornerBitmap(scaleBitmap, 100));
if(selectedList.get(position)== true)
{
convertView.setBackgroundColor(Color.parseColor("#88dfdf"));
}
else
{
convertView.setBackgroundColor(Color.background_light);
}
return convertView;
}
also add the following line to your onListItemClick ().
protected void onListItemClick(ListView l, View v, int position, long id)
{
..................
if(mArrayAdapter.selectedList.get(position)==true)
{
v.setBackgroundColor(Color.background_light));
mArrayAdapter.selectedList.set(position,false);
}
else
{
v.setBackgroundColor(Color.parseColor("#88dfdf"));
mArrayAdapter.selectedList.set(position,true);
Toast.makeText(getApplicationContext(), "Items Pos: " + position +"and Name : "+ name, 0).show();
}
}
and also make the selectedList variable public in the CustomAdapter.
source to share
Another solution, put a simple int in your custom View list
public class CustomListView extends BaseAdapter {
private int selected = 0;
check position in your getView
public View getView(int position, View convertView, ViewGroup parent) {
if (position == selected)
selector.setImageResource(R.drawable.selected);
else
selector.setImageResource(R.drawable.not_selected);
and finally in the clickListener of your activity or fragment, set the position using the setter / getter method and tell the adapter about it.
@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
customListViewAdapter.setSelectedPosition(position);
customListViewAdapter.notifyDataSetChanged();
}
It works like a charm for me;)
source to share