Handle out-of-band TCP data correctly

I wrote a simple client and server to handle out-of-band data. The client simply sends one out-of-band information to the server, and the server uses SIGURG to process that single byte. The server must also handle normal traffic in an infinite loop. The code has a race condition that doesn't work as expected. Sometimes I get "Invalid argument" from the recv () call in the SIGURG handler. Another question is, should I block the SIGURG signal when I call accept? Also, which one is the preferred scenario:

• set a SIGURG handler and set the socket owner for the listening socket before calling accept.
• set a SIGURG handler and set the socket owner for the connected socket after the accept call.
• If you have not indicated any of the above questions, please write your proposal.

My final question is that since the client is sending out-of-band data immediately, is there a chance the server will receive a SIGURG immediately after the 3-way handshake completes, but before returning from accept? If so, I think the "clifd" var may have an invalid value when used in a SIGURG handler.

client code:

#include "myheader.h"

int main(int argc, char *argv[])
{
    struct sockaddr_in saddr;
    int sockfd;

    const char c = 'a';

    if (2 != argc)
    {
        fprintf(stderr, "Usage: %s ipaddr\n", argv[0]);
        exit(EXIT_FAILURE);
    }

    if (-1 == (sockfd = socket(AF_INET, SOCK_STREAM, 0)))
        die("sockfd()");

    (void)memset(&saddr, 0, sizeof(saddr));

    saddr.sin_family = AF_INET;
    saddr.sin_port = htons(PORT);

    if (-1 == inet_pton(AF_INET, argv[1], &saddr.sin_addr))
        die("inet_pton()");

    if (-1 == connect(sockfd, (struct sockaddr*)&saddr, sizeof(saddr)))
        die("connect()");

//  if (-1 == send(sockfd, "HELLO\n", 6, 0))
//      die("send()");

    if (-1 == send(sockfd, &c, 1, MSG_OOB))
        die("send()");

    close(sockfd);

    return 0;
}

      

        
        
        
      

    

and the code for the server:

#include "myheader.h"

void sigurg_handler(int);

char    oob;
int sockfd, clifd;

int main(void)
{
    struct sockaddr_in myaddr;
    char buf[BUFSIZ];
    ssize_t nbytes;
    sigset_t sset, oset;
    sigemptyset(&sset);
    sigaddset(&sset, SIGURG);

    if (-1 == (sockfd = socket(AF_INET, SOCK_STREAM, 0)))
        die("socket()");

    (void)memset(&myaddr, 0, sizeof(myaddr));

    myaddr.sin_family = AF_INET;
    myaddr.sin_port = htons(PORT);
    myaddr.sin_addr.s_addr = htonl(INADDR_ANY);

    if (-1 == bind(sockfd, (struct sockaddr*)&myaddr, sizeof(myaddr)))
        die("bind()");

    if (-1 == listen(sockfd, BACKLOG))
        die("listen()");

    if (-1 == fcntl(sockfd, F_SETOWN, getpid()))
        die("fcntl()");

    if (SIG_ERR == signal(SIGURG, sigurg_handler))
            die("signal()");
    for (;;)
    {
        /* block SIGURG when accepting the connection */
//      sigprocmask(SIG_SETMASK, &sset, &oset);
        printf("bloking in accept()\n");
        if (-1 == (clifd = accept(sockfd, NULL, NULL)))
            die("accept()");

        /* unblock SIGURG */
//      sigprocmask(SIG_SETMASK, &oset, NULL);

        printf("recv()ing normal data\n");
        nbytes = recv(clifd, buf, sizeof(buf), 0);
        buf[nbytes] = 0; /* null-terminate */

        printf("%s", buf);

    }

    close(sockfd);
}

void
sigurg_handler(int signo)
{
    char buff[100];
    ssize_t nbytes;

    printf("SIGURG received\n");
    if (clifd != 0)
    {
        if (-1 == (nbytes = recv(clifd, buff, sizeof(buff) - 1, MSG_OOB)))
            die("recv() in sigurg_handler()");

        buff[nbytes] = 0;
        printf("from sigurg_handler: received \"%s\"\n", buff);
    }
    else
    {
        printf("clifd = %d\n", clifd);
        exit(1);
    }
}

      

        
        
        
      

    

Example:

> ./serv 
bloking in accept()         /* first client */
SIGURG received
from sigurg_handler: received "a"
recv()ing normal data
bloking in accept()         /* second client */
SIGURG received
recv() in sigurg_handler(): Invalid argument
> ./serv             /* third client */
bloking in accept()
SIGURG received
clifd = 0
>