My Paint method works twice and I have no idea why. How can I fix this and does anyone know why this is happening?
The Expo class used is just a shortcut basically, I can link it in case someone wants to run my code. The problem is that only one square that the user can click has to advance them and, by chance, the square that is progressing you change. Therefore, on the first page it is [Fail] [Fail] [Pass], and the next page, which also assumes [Fail] [Fail] [Pass], [Pass] [Pass] [Pass].
EDIT: The Expo class is actually too long to post in it, here is a link to view it, although Link
import java.awt.*;
import java.applet.Applet;
public class BarryViper extends java.applet.Applet
{
Rectangle top, mid, bot;
int numColor;
int pageNum;
public void init()
{
top = new Rectangle(100,75,150,150);
mid = new Rectangle(100,275,150,150);
bot = new Rectangle(100,475,150,150);
numColor = 0;
pageNum = 0;
}
public void paint(Graphics g)
{
switch (pageNum)
{
case 0 : page1(g); break;
case 1 : page2(g); break;
case 2 : page3(g); break;
case 3 : page4(g); break;
// case 4 : page5(g); break;
// case 5 : page6(g); break;
// case 6 : page7(g); break;
// case 7 : page8(g); break;
// case 8 : page9(g); break;
// case 9 : page10(g); break;
}
}
public boolean mouseDown(Event e, int x, int y)
{
if(top.inside(x,y))
numColor = 1;
else if(mid.inside(x,y))
numColor = 2;
else if(bot.inside(x,y))
numColor = 3;
else
numColor = 0;
repaint();
return true;
}
public void page1(Graphics g)
{
Expo.setBackground(g,0);
Expo.setColor(g,Expo.white);
Expo.fillRectangle(g,100,75,250,225);
Expo.fillRectangle(g,100,275,250,425);
Expo.fillRectangle(g,100,475,250,625);
Expo.setFont(g,"Arial",Font.BOLD,20);
Expo.drawString(g,"-You Have been Tasked with slaying the dragon that has forsaken these lands.",260,75);
Expo.drawString(g,"-This quest will be long, difficult, and full of Monty Python refrences.",260,95);
Expo.drawString(g,"-Do you accept this task?",260,115);
Expo.setColor(g,Expo.red);
Expo.setFont(g,"Arial",Font.BOLD,15);
Expo.drawString(g,"Nah",155,155);
Expo.drawString(g,"I Prefer",145,350);
Expo.drawString(g,"Monty Java",130,370);
Expo.drawString(g,"Sure I could",130,540);
Expo.drawString(g,"waste some time",115,560);
switch (numColor)
{
case 0 : pageNum=0; break;
case 1 : pageNum=0; break;
case 2 : pageNum=0; break;
case 3 : pageNum=1; break;
}
}
public void page2(Graphics g)
{
Expo.setBackground(g,0);
Expo.setColor(g,Expo.white);
Expo.fillRectangle(g,100,75,250,225);
Expo.fillRectangle(g,100,275,250,425);
Expo.fillRectangle(g,100,475,250,625);
Expo.setFont(g,"Arial",Font.BOLD,20);
Expo.drawString(g,"-Good Choice! You now decide to roam down an old dirt road, when suddenly",260,75);
Expo.drawString(g,"-You encounter a group of three Goblins blocking your path",260,95);
Expo.drawString(g,"-What is your reaction?",260,115);
Expo.setColor(g,Expo.red);
Expo.setFont(g,"Arial",Font.BOLD,15);
Expo.drawString(g,"Hide from them ",115,155);
Expo.drawString(g,"Try talking",130,350);
Expo.drawString(g,"To them",130,370);
Expo.drawString(g,"Attack them",130,540);
Expo.drawString(g,"immediately",130,560);
switch (numColor)
{
case 0 : pageNum=0; break;
case 1 : pageNum=0; break;
case 2 : pageNum=0; break;
case 3 : pageNum=2; break;
}
}
public void page3(Graphics g)
{
Expo.setBackground(g,0);
Expo.setColor(g,Expo.white);
Expo.fillRectangle(g,100,75,250,225);
Expo.fillRectangle(g,100,275,250,425);
Expo.fillRectangle(g,100,475,250,625);
Expo.setFont(g,"Arial",Font.BOLD,75);
Expo.drawString(g,"PAGE 3",200,75);
switch (numColor)
{
case 0 : pageNum=0; break;
case 1 : pageNum=0; break;
case 2 : pageNum=0; break;
case 3 : pageNum=3; break;
}
}
public void page4(Graphics g)
{
Expo.setBackground(g,0);
Expo.setColor(g,Expo.white);
Expo.fillRectangle(g,100,75,250,225);
Expo.fillRectangle(g,100,275,250,425);
Expo.fillRectangle(g,100,475,250,625);
Expo.setFont(g,"Arial",Font.BOLD,75);
Expo.drawString(g,"PAGE 4",200,75);
switch (numColor)
{
case 0 : pageNum=0; break;
case 1 : pageNum=0; break;
case 2 : pageNum=0; break;
case 3 : pageNum=4; break;
}
}
}
+3
source to share
1 answer
In fact, paint () is called anytime the system needs to repaint the window. You can resize, move or hide the window. paint () is called every time. Drag another window over yours and you can see how many times paint () is called.
So, don't use paint fr of any logic. Use the MVC pattern and separate your picture from the logic.
Specifically - keep your color in your model and change it based on mouse click. Then paint () has to use the current color value, but not decide what color it has.
If you want to see the code, here it is:
import java.awt.*;
import java.applet.Applet;
public class BarryViper extends java.applet.Applet {
Rectangle top, mid, bot;
int numColor;
int pageNum;
public void init() {
top = new Rectangle(100, 75, 150, 150);
mid = new Rectangle(100, 275, 150, 150);
bot = new Rectangle(100, 475, 150, 150);
numColor = 0;
pageNum = 0;
}
public void paint(Graphics g) {
switch (pageNum) {
case 0:
page1(g);
break;
case 1:
page2(g);
break;
case 2:
page3(g);
break;
case 3:
page4(g);
break;
}
}
public boolean mouseDown(Event e, int x, int y) {
if (top.inside(x, y))
numColor = 1;
else if (mid.inside(x, y))
numColor = 2;
else if (bot.inside(x, y))
numColor = 3;
else
numColor = 0;
switch (numColor) {
case 0:
pageNum = 0;
break;
case 1:
pageNum = 0;
break;
case 2:
pageNum = 0;
break;
case 3:
pageNum = pageNum;
break;
}
repaint();
return true;
}
public void page1(Graphics g) {
Expo.setBackground(g, 0);
Expo.setColor(g, Expo.white);
Expo.fillRectangle(g, 100, 75, 250, 225);
Expo.fillRectangle(g, 100, 275, 250, 425);
Expo.fillRectangle(g, 100, 475, 250, 625);
Expo.setFont(g, "Arial", Font.BOLD, 20);
Expo.drawString(
g,
"-You Have been Tasked with slaying the dragon that has forsaken these lands.",
260, 75);
Expo.drawString(
g,
"-This quest will be long, difficult, and full of Monty Python refrences.",
260, 95);
Expo.drawString(g, "-Do you accept this task?", 260, 115);
Expo.setColor(g, Expo.red);
Expo.setFont(g, "Arial", Font.BOLD, 15);
Expo.drawString(g, "Nah", 155, 155);
Expo.drawString(g, "I Prefer", 145, 350);
Expo.drawString(g, "Monty Java", 130, 370);
Expo.drawString(g, "Sure I could", 130, 540);
Expo.drawString(g, "waste some time", 115, 560);
}
public void page2(Graphics g) {
Expo.setBackground(g, 0);
Expo.setColor(g, Expo.white);
Expo.fillRectangle(g, 100, 75, 250, 225);
Expo.fillRectangle(g, 100, 275, 250, 425);
Expo.fillRectangle(g, 100, 475, 250, 625);
Expo.setFont(g, "Arial", Font.BOLD, 20);
Expo.drawString(
g,
"-Good Choice! You now decide to roam down an old dirt road, when suddenly",
260, 75);
Expo.drawString(g,
"-You encounter a group of three Goblins blocking your path",
260, 95);
Expo.drawString(g, "-What is your reaction?", 260, 115);
Expo.setColor(g, Expo.red);
Expo.setFont(g, "Arial", Font.BOLD, 15);
Expo.drawString(g, "Hide from them ", 115, 155);
Expo.drawString(g, "Try talking", 130, 350);
Expo.drawString(g, "To them", 130, 370);
Expo.drawString(g, "Attack them", 130, 540);
Expo.drawString(g, "immediately", 130, 560);
}
public void page3(Graphics g) {
Expo.setBackground(g, 0);
Expo.setColor(g, Expo.white);
Expo.fillRectangle(g, 100, 75, 250, 225);
Expo.fillRectangle(g, 100, 275, 250, 425);
Expo.fillRectangle(g, 100, 475, 250, 625);
Expo.setFont(g, "Arial", Font.BOLD, 75);
Expo.drawString(g, "PAGE 3", 200, 75);
}
public void page4(Graphics g) {
Expo.setBackground(g, 0);
Expo.setColor(g, Expo.white);
Expo.fillRectangle(g, 100, 75, 250, 225);
Expo.fillRectangle(g, 100, 275, 250, 425);
Expo.fillRectangle(g, 100, 475, 250, 625);
Expo.setFont(g, "Arial", Font.BOLD, 75);
Expo.drawString(g, "PAGE 4", 200, 75);
}
}
This is the idea - move the logic to the controller - mouselistener in your case. This example is for pagenumber only. The same should be done for texts. All texts must be in the model, and in general you should only have one drawing method that draws the texts from your model. So these pageN () methods should go away as well.
+5
source to share