Bad URI (not URI?) In Rspec tests

I have these weird problems, I don't know how to fix it. Please help me if you can.

Here is the test result:

1) Admin can edit a hotel
     Failure/Error: visit edit_admin_hotel_path(hotel)
     URI::InvalidURIError:
       bad URI(is not URI?): 
     # ./spec/requests/admin_spec.rb:32:in `block (2 levels) in <top (required)>'

  2) Admin can edit a user
     Failure/Error: visit edit_admin_user_path(admin)
     URI::InvalidURIError:
       bad URI(is not URI?): 
     # ./spec/requests/admin_spec.rb:54:in `block (2 levels) in <top (required)>'

      

rake routes

shows me good editing routes for users and hotels:

edit_admin_hotel  GET  /admin/hotels/:id/edit(.:format)   admin/hotels#edit
edit_admin_user   GET  /admin/users/:id/edit(.:format)     admin/users#edit

      

And everything works fine if I start the server and check it manually. So I have no idea where these problems come from. Thanks for any help! And my admin_spec.rb file:

require 'spec_helper'

describe "Admin"  do
    let(:admin) { FactoryGirl.create(:user) }
    let(:hotel) { FactoryGirl.create(:hotel) }


    before(:each) do
        sign_up_as_admin admin
        visit admin_hotels_path
    end

    subject { page }

    it { expect(page).to have_content("Manage Hotels") }
    it { expect(page).to have_content("Manage Users") }
    it { expect(page).to have_link("Sign out") }
    it { expect(page).to have_content("List of hotels") }
    it { expect(page).to have_content("Hello, Admin") }

    it "can add a hotel" do
        click_link "Add Hotel"
        expect(current_path).to eq(new_admin_hotel_path)
        fill_in 'name', with: "TestHotel"
        fill_in 'price', with: "666"
        fill_in 'star_rating', with: "5"
        expect { click_button "Submit" }.to change(Hotel,:count).by(1)
        expect(current_path).to eq(admin_hotel_path(1))
    end

    it "can edit a hotel" do
        visit edit_admin_hotel_path(hotel)
    end

    it "can delete a hotel" do
        visit admin_hotel_path(hotel)
        expect { click_link "Delete hotel" }.to change(Hotel,:count).by(-1)
        #expect { click_link "Delete hotel" }.to redirect_to(admin_hotels_path)
    end

    it "can create a new user" do
        click_link "Add User"
        expect(current_path).to eq(new_admin_user_path)
        expect(page).to have_content("Create New User")
        fill_in "Name",    :with => "user"
        fill_in "Email",    :with => "user@auser.com"
        fill_in "Password", :with => "user.password"
        fill_in "password_confirmation", :with => "user.password"
        expect { click_button "Create User" }.to change(User,:count).by(1)
        expect(current_path).to eq(admin_users_path)
    end

    it "can edit a user" do
        visit edit_admin_user_path(admin)
    end
end

      

Change / update actions in users_controller.rb:

# GET admin/users/1/edit
  def edit
    @user = User.find(params[:id])
    render "edit", status: 302
  end

  # PATCH/PUT admin/users/1
  def update
    @user = User.find(params[:id])
    if @user.try(:update_attributes, user_params)
      render "edit", notice: 'User was successfully updated.'
    else
      render action: 'edit'
    end
  end

  private

    def user_params
      params.require(:user).permit(:name, :email, :password,
                                   :password_confirmation, :admin)
    end

      

And user /edit.html.erb:

<% provide(:title, "Edit user") %>
<h1>Update profile</h1>

<div class="row">
  <div class="span6 offset3">
    <%= form_for([:admin, @user]) do |f| %>
      <%= render 'shared/error_messages', object: f.object %>

      <%= f.label :name %>
      <%= f.text_field :name %>

      <%= f.label :email %>
      <%= f.text_field :email %>

      <%= f.label :password %>
      <%= f.password_field :password %>

      <%= f.label :password_confirmation, "Confirm Password" %>
      <%= f.password_field :password_confirmation %>

      <%= f.submit "Save changes" %>
    <% end %>
      <%= button_to 'Delete User', [:admin, @user], :data => {     confirm: 'Are you sure?' }, method: :delete %>
  </div>
</div>

      

Update 1: I found these errors bad URI(is not URI?)

also in hotel_controller and comment_controller while testing the edit action. These errors are in all my controllers in edit actions and I don't know what bites them :(

+3


source to share





All Articles