Php delete file using unlink before updating database row
I am creating a CRUD and realized that I would need to delete the image that is stored in the directory if the user wants to upload a new image.
I have a web page with a form that prints information from a database string using an ID and then updates the values to the script where the problem is.
I am trying to find the file to be deleted using this:
$target_dir = "images/photo/";
$del_image = $_FILES["image"];
And trying to set file permissions like this:
$change = chmod($del_image,0644);
Then try deleting the file with this:
$delete = unlink($target_dir.$image);
Before updating everything with this:
$target_file = $target_dir . basename($_FILES["image"]["name"]);
$file = $target_dir . basename($_FILES["ud_image"]["name"]);
$uploadOk = 1;
if (move_uploaded_file($_FILES["ud_image"]["tmp_name"], $file))
{
echo '<script type="text/javascript">';
echo 'alert("News Items Saved")';
echo '</script>';
} else {
echo "Sorry, there was an error with your file.";
}
$id = intval($_GET['id']);
$ud_headline = $_POST["ud_headline"]; //mysql_real_escape_string()
$ud_body = $_POST["ud_body"]; //mysql_real_escape_string()
$ud_image = $_POST["ud_image"]; //mysql_real_escape_string()
$query="UPDATE news SET
headline = '$ud_headline',
body = '$ud_body',
image = '$ud_image'
WHERE id='$ud_id'";
$mysqli->query($query)or die($mysqli->error);
if($mysqli->affected_rows>=1){
echo "<script type='text/javascript'>";
echo "alert('News Item Updated');";
echo 'document.location.href = "/pc.v.2/admin-news.php";';
echo "</script>;";
}
else
{
echo "<script type='text/javascript'>";
echo "alert('News Item Not Updated'. $mysqli->error);";
echo "</script>";
//echo "Error deleting record: " . $conn->error;
}
The errors I'm getting tell me that I didn't even find the directory correctly, let alone the file.
This is the form:
<form action="update.php" method="post" class="newNews">
<input type="hidden" name="ud_id" value="<?=$id;?>">
<!-- <input type="hidden" name="old_id" value="<?=$image;?>"> -->
<label for="title">Title</label>
<input type="text" name="ud_headline" value="<?=$headline;?>"/><br />
<label for="text">Body</label>
<textarea name="ud_body" rows="15" cols="21" value=""><?=$body;?></textarea><br />
<p>Current Photo</p>
<img src="<?=$target_dir.$image?>" alt=''><br />
<input type="file" name="ud_image" class="newsImage" ><br />
<input type="submit" name="submit" value="Update news item" class='addNew' />
</form>
How can I fix this?
source to share
PHP will move_uploaded_file()
actually overwrite the old file, so you really don't need to do the redundant unlink()
.
Since we do not have access to your server, we cannot tell exactly what the matter is. But it can be one (or more) of them:
- Make sure yours is
$target_dir
added using$_SERVER['DOCUMENT_ROOT'].'/'
or your server's root path for example.'/var/www/'
... - Make sure the folders actually exist.
- Make sure your web server has write access to folders.
- (good practice) Check for file errors before uploading
I would do this for troubleshooting:
// Derive target paths
$target_dir = $_SERVER['DOCUMENT_ROOT'].'/images/photo/';
$target_path = $target_dir . basename($_FILES["ud_image"]["name"]);
// Check target dir exists and is writable
if (!file_exists($target_dir )) {
// Try to automatically create the folders
umask(0);
if (!mkdir($target_dir , 0777, true)) { // or whatever permissions
// Do your error handling here
echo 'Sorry, target directory does not exist and we could not create it automatically.';
exit(1);
}
}
if (!is_writable($target_dir)) {
// Do your error handling here
echo 'Sorry, the directory is not writable.';
exit(1);
}
// Check for file errors
if (!isset($_FILES["ud_image"]["tmp_name"])) {
echo 'Sorry, no upload file detected.';
exit(1);
}
if ($_FILES["ud_image"]["error"] > 0) {
echo 'Sorry, there was an error with the file. Error code: '.$_FILES["ud_image"]["error"]);
exit(1);
}
// Move uploaded file
if (!move_uploaded_file($_FILES["ud_image"]["tmp_name"], $target_path)) {
// Do your error handling here
echo "Sorry, there was an error with the upload operation.";
exit(1);
}
// If you reach here, the upload should have succeeded. Go on to do whatever else you need to do
echo '<script>alert('News Item saved')</script>';
Just by the way - echo
showing in server-side code is probably not a good idea, but that's beyond the point. It's best to keep presentation and logic separate for convenience and ease of troubleshooting.
source to share