Swing multithreading issues around create / destroy dialog
Possible duplicate:
SwingWorker in Java
I have several classes that need to work together, but they are not.
First, I have Main:
public class Main
{
public static void main(String[] args)
{
SwingUtilities.invokeLater(new Runnable()
{
@Override
public void run()
{
//JFrame dummy for JDialog errors
modal = new JFrame();
new PrimaryErrorDialog("Title", "Message", e, false);
JFrame masterWindow = new JFrame();
masterWindow.setVisible();
}
}
}
}
It creates a PrimaryErrorDialog class:
private JDialog dialog = this;
private JTextArea text;
private JPanel buttonContainer;
private JButton sendErrorReportT, sendErrorReportF;
public PrimaryErrorDialog(String title, String message,
final Exception error, final boolean exit)
{
super(Main.modal, title, true);
//JButton for sending error report
sendErrorReportT = new JButton("Send Error Report");
sendErrorReportT.addActionListener(new ActionListener()
{
@Override
public void actionPerformed(ActionEvent e)
{
dialog.dispose();
dialog = new JDialog(Main.modal, "Sending...", true);
Worker thread = new Worker(error);
thread.start();
JProgressBar progress = new JProgressBar();
progress.setIndeterminate(true);
dialog.add(progress);
dialog.pack();
dialog.setVisible(true);
}
});
//JButton for not sending error report
sendErrorReportF = new JButton("Don't send error report");
sendErrorReportF.addActionListener(new ActionListener()
{
@Override
public void actionPerformed(ActionEvent e)
{
dialog.dispose();
if (exit)
{
System.exit(0);
}
}
});
buttonContainer = new JPanel();
buttonContainer.add(sendErrorReportT);
buttonContainer.add(sendErrorReportF);
add(text);
add(buttonContainer);
pack();
setLocationRelativeTo(null);
setVisible(true);
}
public void cleanUpAndContinue()
{
dialog.dispose();
dialog = new JDialog(Main.modal, "title", true);
dialog.add(/*Jbutton with listener that disposes this dialog*/)
dialog.setVisible(true);
}
It calls the Worker class, which extends Thread:
public class Worker extends Thread
{
Exception e;
public Worker(Exception error)
{
e = error;
}
@Override
public void run()
{
//do something that takes time
PrimaryErrorDialog.cleanUpAndContinue();
}
It falls back to the PrimaryErrorDialog, which will then have to inform the user that the task has been completed and then terminate that dialog.
Then we go back to main where masterWindow is created.
All of this code is executed before masterWindow is created, since this segment is triggered when an error occurs (if LAF is missing, no .proprties files, etc.) ...
This is why I created a dummy JFrame so the JDialog can attach to it, I didn't want to turn it into a JFrame.
This code is also executed later in the program, for "real" runtime errors some classes have several different parameters and / or constructors.
However it doesn't work, I tried it in milion ways, I tried with SwingWorker, nothing seems to do what I want. Usually the email code isn't even reached, or the program doesn't wait for the dialogs to be installed ...
And what do I need?
Mistake. A dialog pops up telling me that an error has occurred and asks if I would like to submit a bug report. I say no - the dialogue is closed, canceling the entire program if the error is fatal. I say yes - the dialog closes, a new one opens with an undefined progress bar when an email with a stacktrace is sent in the background. An email is sent, the progress bar dialog closes, and a new one opens, informing me that my bug report has been sent. I click ok and the dialog is closed, killing the entire program if the error is fatal, otherwise it continues where it is left from the main class.
Note. The error can occur in any class, it is not only from Main ...
source to share
I haven't read your previous question yet ...
The main problem you have to run into is to notify the dialog (which is within the EDT) that the background thread has terminated (and also provide user feedback if possible).
This is covered in the Concurrency in Swing tutorial .
Below is a simple proof of concept. Personally, I used to create a custom panel and put it on a JDialog
, but this is just a proof of concept.
public class TestSwingWorker {
public static void main(String[] args) {
EventQueue.invokeLater(new Runnable() {
@Override
public void run() {
try {
UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
} catch (ClassNotFoundException ex) {
} catch (InstantiationException ex) {
} catch (IllegalAccessException ex) {
} catch (UnsupportedLookAndFeelException ex) {
}
final JDialog dialog = new JDialog((Frame)null, "Happy, Happy, Joy, Joy", true);
// This is so I can get my demo to work, you won't need it...
dialog.addWindowListener(new WindowAdapter() {
@Override
public void windowClosing(WindowEvent e) {
System.exit(0);
}
});
JPanel panel = new JPanel(new GridBagLayout());
panel.setBorder(new EmptyBorder(8, 8, 8, 8));
dialog.setContentPane(panel);
// You'll need you own icon...
JLabel lblIcon = new JLabel(new ImageIcon(getClass().getResource("/waiting-64.png")));
JLabel lblMessage = new JLabel("<html>Hard and work here<br>Please wait...</html>");
final JProgressBar progressBar = new JProgressBar();
GridBagConstraints gbc = new GridBagConstraints();
gbc.gridx = 0;
gbc.gridy = 0;
gbc.anchor = GridBagConstraints.NORTH;
gbc.weighty = 1;
gbc.insets = new Insets(2, 2, 2, 2);
gbc.gridheight = GridBagConstraints.REMAINDER;
dialog.add(lblIcon, gbc);
gbc.gridheight = 1;
gbc.gridx = 1;
gbc.gridy = 0;
gbc.anchor = GridBagConstraints.WEST;
gbc.weighty = 0;
gbc.weightx = 1;
dialog.add(lblMessage, gbc);
gbc.gridy = 1;
gbc.anchor = GridBagConstraints.NORTH;
gbc.weighty = 1;
dialog.add(progressBar, gbc);
dialog.pack();
dialog.setLocationRelativeTo(null);
MyWorker worker = new MyWorker();
// Get notification back from the worker...
worker.addPropertyChangeListener(new PropertyChangeListener() {
@Override
public void propertyChange(PropertyChangeEvent evt) {
MyWorker worker = (MyWorker) evt.getSource();
// Progress has been updated
if (evt.getPropertyName().equalsIgnoreCase("progress")) {
progressBar.setValue((Integer)evt.getNewValue());
// The state of the worker has changed...
} else if (evt.getPropertyName().equalsIgnoreCase("state")) {
if (worker.getState().equals(SwingWorker.StateValue.DONE)) {
dialog.dispose();
}
}
}
});
worker.execute();
dialog.setVisible(true);
}
});
}
protected static class MyWorker extends SwingWorker<Object, Object> {
@Override
protected Object doInBackground() throws Exception {
// My long running task...
for (int index = 0; index < 100; index++) {
// Change this to make it faster or slower...
Thread.sleep(250);
setProgress(index);
}
return null;
}
}
}
source to share
-
dirty wrap
dialog.setVisible(true);
ininvokeLater()
-
use
SwingWorker
eitherRunnable#Thread
instead of or justThread
-
Is there a problem that you ignored the answers and especially the comments from your previous question.
-
Swing Gui doesn't care about exiting Thread because there are no injected notifications for Event Dispatch Thread, you have to call this with invokeLater or use
SwingWorker
, -
SwingWorkers
methodsdone
,publish
andprogress
can notify EDT correctly
source to share