How to fix an OutOfMemoryError thrown when trying to throw an OutOfMemoryError with a modified

I am using retrofit to download some media like video, mp3, jpg, pdf, ... in my application. This is a problem when I want to download a large file with 55 MB in mp4 format. when i want to download this file i get an error:

OutOfMemoryError threw while trying to throw OutOfMemoryError; no stack trace available

      

this is my code:

  private void downloadFile() {

    ArrayList<FileModel> filesInDB = G.bootFileFromFileDB();

    for (final FileModel fm : filesInDB) {

      APIService downloadService = ServiceGenerator.createServiceFile(APIService.class, "username", "password");

      //Id of apk file that you want to download
      Call<ResponseBody> call = downloadService.downloadFileWithDynamicUrlSync("file/download/" + String.valueOf(fm.getFileId()));
      call.enqueue(new Callback<ResponseBody>() {

        @Override
        public void onResponse(Call<ResponseBody> call, Response<ResponseBody> response) {
          if (response.isSuccess()) {

            Log.d("LOGOO", "server contacted and has file");

            boolean writtenToDisk = writeResponseBodyToDisk(response.body(), fm.getFileName(), fm.getFileExtension());

            response = null;


            Log.d("LOGOO", "file download was a success? " + writtenToDisk);


          } else {
            Log.d("LOGOO", "server contact failed");
          }
        }

        @Override
        public void onFailure(Call<ResponseBody> call, Throwable t) {
          Log.i("LOGO", "Error is : " + t.getMessage());

          Toast.makeText(ActivityInternet.this, R.string.internet_error, Toast.LENGTH_LONG).show();
          Intent intent = new Intent(ActivityInternet.this, ActivityStartup.class);
          startActivity(intent);
        }
      });
    }

      

and this is the writeResponseBodyToDisk method I am using:

  private boolean writeResponseBodyToDisk(ResponseBody body, String fileName, String fileExtension) {

    try {

      // Location to save downloaded file and filename
      File futureStudioIconFile = new File(G.DIR_APP + fileName + fileExtension);
      InputStream inputStream = null;
      OutputStream outputStream = null;
      try {
        byte[] fileReader = new byte[4096];
        long fileSize = body.contentLength();
        long fileSizeDownloaded = 0;
        inputStream = body.byteStream();
        outputStream = new FileOutputStream(futureStudioIconFile);
        while (true) {
          int read = inputStream.read(fileReader);
          if (read == -1) {
            break;
          }
          outputStream.write(fileReader, 0, read);
          fileSizeDownloaded += read;
          Log.d("LOGO", "file download: " + fileSizeDownloaded + " of " + fileSize);
        }
        outputStream.flush();
        return true;
      } catch (IOException e) {
        return false;
      } finally {
        if (inputStream != null) {
          inputStream.close();
        }
        if (outputStream != null) {
          outputStream.close();
        }
      }
    } catch (IOException e) {
      return false;
    }


  }

      

Finally, this is my createServiceFile method:

public static <S> S createServiceFile(Class<S> serviceClass, String username, String password) {
        if (username != null && password != null) {

            String credentials = username + ":" + password;
            final String basic =
              "Basic " + Base64.encodeToString(credentials.getBytes(), Base64.NO_WRAP);
            httpClient.addInterceptor(new Interceptor() {
                @Override
                public Response intercept(Chain chain) throws IOException {
                    Request original = chain.request();
                    Request.Builder requestBuilder = original.newBuilder()
                      .header("Authorization", basic)
                      .header("Accept", "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,audio/mp4,image/jpeg,*/*;q=0.8")
                      .method(original.method(), original.body());
                    Request request = requestBuilder.build();
                    return chain.proceed(request);
                }
            });
        }
        OkHttpClient client = httpClient.build();
        Retrofit retrofit = builder.client(client).build();
        return retrofit.create(serviceClass);
    }

      

I really appreciate if you can help me :)

+3


source to share


1 answer


When processing a large number of files while updating, 4 things can be noticed:



  • Make sure you use largeHeap=true

    in AndroidManifest.xml

    as an attribute for <application>

    .
  • Make sure you use the annotation @Streaming

    from Retrofit to pass the solution and not count it as a whole, which is where memory is stored.
  • Process the response using AsyncTask

    as described in this link . In your case, this means calling writeResponseBodyToDisk

    from AsyncTask

    .
  • The last thing to avoid is using a protocol interceptor Level.BODY

    okhttp3

    . Using it alongside a streamed response still keeps the entire response corpus in memory, which negates the benefit of the support @Streaming

    provided by modification.
+5


source







All Articles