Logical problem in Python code
I am new to Python, I am writing a simple program
Input
{'messagingservice': 'build4',
'oltpdatabase': 'build1',
'paymentsdatabase': 'build2',
'restserver': 'build5',
'PESQL': 'build3',
'configdatabase': 'build1'}
expected result is below
{'build4': 'messagingservice',
'build5': 'restserver',
'build2': 'paymentsdatabase',
'build3': 'PESQL',
'build1': 'oltpdatabase,configdatabase '}
Below is the code I used ...
#!/usr/bin/python
import json
import ast
from sys import argv
data = json.dumps(argv[1]);
json_to_unicode = json.loads(data)
unicode_to_dic = ast.literal_eval(json_to_unicode);
print(unicode_to_dic);
result_dic={};
data='';
for k,v in unicode_to_dic.iteritems():
if v in result_dic:
data=data.join((result_dic[v],','));
print (data)
result_dic[v]=data
else:
result_dic[v]=k;
print(result_dic)
Actual conclusion:
{'build4': 'messagingservice',
'build5': 'restserver',
'build2': 'paymentsdatabase',
'build3': 'PESQL',
'build1': 'oltpdatabase,'}
Another value is missing.
source to share
your connection has not joined a new item
result_dic={}
data=''
for k,v in d.iteritems():
if v in result_dic.keys():
data=data.join((result_dic[v],', ',k))
result_dic[v]=data
else:
result_dic[v]=k
print(result_dic)
returns
{'build4': 'messagingservice', 'build5': 'restserver', 'build2': 'paymentsdatabase', 'build3': 'PESQL', 'build1': 'oltpdatabase, configdatabase'}
you can also use collections.Counter
from collections import Counter
new =Counter()
d={'messagingservice': 'build4', 'oltpdatabase': 'build1', 'paymentsdatabase': 'build2', 'restserver': 'build5', 'PESQL': 'build3','configdatabase': 'build1'}
for k,v in d.items():
if new[v]:
new[v]+=', '+k
else:
new[v]=k
print new
returns
Counter({'build1': 'oltpdatabase, configdatabase',
'build2': 'paymentsdatabase',
'build3': 'PESQL',
'build4': 'messagingservice',
'build5': 'restserver'})
source to share
You can use defaultdict
, which can make the program much easier:
unicode_to_dic = {
'messagingservice': 'build4',
'oltpdatabase': 'build1',
'paymentsdatabase': 'build2',
'restserver': 'build5',
'PESQL': 'build3',
'configdatabase': 'build1'}
from collections import defaultdict
res = defaultdict(list)
# find all keys that have the same value
for key, value in unicode_to_dic.items():
res[value].append(key)
# convert the list of keys to a string seperated by ','
for key, value in res.items():
res[key] = ','.join(value)
# Convert it to a normal dict - that optional because defaultdict behaves just
# like a normal dict (in most circumstances at least).
dict(res)
# {'build1': 'oltpdatabase,configdatabase',
# 'build2': 'paymentsdatabase',
# 'build3': 'PESQL',
# 'build4': 'messagingservice',
# 'build5': 'restserver'}
I haven't debugged your algorithm, but there are a few things that stand out:
-
Python doesn't need
;
line ends. -
str.join
actually calledseperator.join(list_of_words_to_be_joined)
. You used a delimiter as input to a function.
source to share