Java for multiple loop variables

Question

Java for multiple loop variables

I'm not sure why my Java code will not compile, any suggestions would be appreciated.

   String rank = card.substring(0,1);
    String suit = card.substring(1);
    String cards = "A23456789TJQKDHSCl";
    String[] name = {"Ace","Two","Three","Four","Five","Six","Seven","Eight","Nine","Ten","Jack","Queen","King","Diamonds","Hearts","Spades","Clubs"};
    String c ="";
    for(int a = 0, b = 1; a<cards.length-1; b=a+1; a++;){
        if(rank===cards.substring(a,b){
            c+=name[a];
        }


    }
    system.out.println(c);

+3

java

Caleb hutchinson 07 Feb 13 at 13:41

source to share

9 replies

Andreas Fester · Answer 1 · 2013-02-07T13:43:51+0000

cards.length()

, not cards.length

( length

is a method java.lang.String

, not an attribute ).
It's System.out

(capital's), not System.out

. See java.lang.System .

it

for(int a = 0, b = 1; a<cards.length()-1; b=a+1, a++){

not

for(int a = 0, b = 1; a<cards.length-1; b=a+1; a++;){

Syntactically it is if(rank == cards.substring(a,b)){

, not if(rank===cards.substring(a,b){

(doubles are equal, not thrice equal; there is no closing parenthesis), but for comparison, if the two strings are equal, you need to use equals()

:if(rank.equals(cards.substring(a,b))){

You should probably consider downloading Eclipse , which is an integrated development environment (not only) for Java development. Eclipse shows you errors as you type and also provides help to fix them. This makes Java development much easier.

Abubakkar · Answer 2 · 2013-02-07T13:43:52+0000

Instead of this: for(int a = 0, b = 1; a<cards.length-1; b=a+1; a++;){

It should be

for(int a = 0, b = 1; a<cards.length()-1; b=a+1, a++){
                                     ^         ^    ^  
                                     |         |    |  
                                     |         |    |  
            -------------------------------------------Note the changes
           |                    
           v                                                  |
   if(rank==cards.substring(a,b){                             |
-------------------------------------------------------------                                  
|
v
System.out.println(c); //capital S in system

Yogesh Ralebhat · Answer 3 · 2013-02-07T14:00:08+0000

for

Only two semicolons are allowed in a loop .

Before the first semicolon is part of the initialization.
After the first semicolon and before the second semicolon is part of the condition (boolean must be met).
After the second semicolon, the part of the manipulation variable (part of the increase / decrease).

If you are initializing multiple variables or manipulating multiple variables, you can achieve this by separating them with a comma (,).

for(int i=0, j=5; i < 5; i++, j--)

NOTE. Multiple conditions separated by commas are NOT allowed.

for(int i=0, j=5; i < 5, j > 5; i++, j--) // This is NOT allowed.

vici · Answer 4 · 2013-02-07T13:48:48+0000

I think this should work:

    String rank = card.substring(0,1);
    String suit = card.substring(1);
    String cards = "A23456789TJQKDHSCl";

    String[] name = {"Ace","Two","Three","Four","Five","Six","Seven","Eight","Nine","Ten","Jack","Queen","King","Diamonds","Hearts","Spades","Clubs"};
    String c ="";
    for(int a = 0, b = 1; a<cards.length()-1; b=a+1, a++ )
    {
        if( rank.equals( cards.substring(a,b) ) )
        {
            c+=name[a];
        }


    }
    System.out.println(c);

xlecoustillier · Answer 5 · 2013-02-07T13:43:28+0000

Your for loop is wrong. Try:

for(int a = 0, b = 1; a<cards.length()-1; b=a+1, a++){

Also, System

instead of System

and ==

instead of ===

.

But I'm not sure what you are trying to do.

NEO · Answer 6 · 2013-02-07T13:43:38+0000

The for loop can only contain the three parameters you used 4. Please repeat the question, what do you want to achieve?

0

NEO 07 Feb 13 at 13:43

source to share

Ivaylo Strandjev · Answer 7 · 2013-02-07T13:43:41+0000

Separate the increments with a comma.

for(int a = 0, b = 1; a<cards.length-1; b=a+1, a++)

Satya · Answer 8 · 2013-02-07T13:43:59+0000

change this line

for(int a = 0, b = 1; a<cards.length-1; b=a+1; a++;){

to

for(int a = 0, b = 1; a<cards.length-1, b=a+1; a++){

Michael A · Answer 9 · 2013-02-07T13:45:37+0000

Your loop is for

wrong; - it cannot take 4 arguments, and you cannot combine two with ;

as you did.

Using:

for(int a = 0, b = 1; a<cards.length-1; a++)

Java for multiple loop variables

More articles: